Changeset b7fd2a0 in mainline for uspace/lib/usbdev/src/pipesinit.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/usbdev/src/pipesinit.c (modified) (6 diffs)

uspace/lib/usbdev/src/pipesinit.c

@@ -152 +152 @@
  * @return Error code.
  */
-static int process_endpoint(
+static errno_t process_endpoint(
     usb_endpoint_mapping_t *mapping, size_t mapping_count,
     usb_standard_interface_descriptor_t *interface,
@@ -194 +194 @@
         }
 
-        int rc = usb_pipe_initialize(&ep_mapping->pipe,
+        errno_t rc = usb_pipe_initialize(&ep_mapping->pipe,
             ep_no, description.transfer_type,
             ED_MPS_PACKET_SIZE_GET(
@@ -221 +221 @@
  * @return Error code.
  */
-static int process_interface(
+static errno_t process_interface(
     usb_endpoint_mapping_t *mapping, size_t mapping_count,
     const usb_dp_parser_t *parser, const usb_dp_parser_data_t *parser_data,
@@ -281 +281 @@
  * @return Error code.
  */
-int usb_pipe_initialize_from_configuration(
+errno_t usb_pipe_initialize_from_configuration(
     usb_endpoint_mapping_t *mapping, size_t mapping_count,
     const uint8_t *config_descriptor, size_t config_descriptor_size,
@@ -338 +338 @@
  * @return Error code.
  */
-int usb_pipe_probe_default_control(usb_pipe_t *pipe)
+errno_t usb_pipe_probe_default_control(usb_pipe_t *pipe)
 {
         assert(pipe);
@@ -351 +351 @@
         uint8_t dev_descr_start[CTRL_PIPE_MIN_PACKET_SIZE];
         size_t transferred_size;
-        int rc;
+        errno_t rc;
         for (size_t attempt_var = 0; attempt_var < 3; ++attempt_var) {
                 rc = usb_request_get_descriptor(pipe, USB_REQUEST_TYPE_STANDARD,