Changeset b7fd2a0 in mainline for uspace/lib/usbhid/src/hidreport.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/usbhid/src/hidreport.c (modified) (4 diffs)

uspace/lib/usbhid/src/hidreport.c

@@ -50 +50 @@
 #include <usb/hid/hidreport.h>
 
-static int usb_hid_get_report_descriptor(usb_device_t *dev,
+static errno_t usb_hid_get_report_descriptor(usb_device_t *dev,
     uint8_t **report_desc, size_t *size)
 {
@@ -135 +135 @@
          * Get the descriptor from the device.
          */
-        int rc = usb_request_get_descriptor(usb_device_get_default_pipe(dev),
+        errno_t rc = usb_request_get_descriptor(usb_device_get_default_pipe(dev),
             USB_REQUEST_TYPE_STANDARD, USB_REQUEST_RECIPIENT_INTERFACE,
             USB_DESCTYPE_HID_REPORT, 0, usb_device_get_iface_number(dev),
@@ -163 +163 @@
 
 
-int usb_hid_process_report_descriptor(usb_device_t *dev, 
+errno_t usb_hid_process_report_descriptor(usb_device_t *dev, 
     usb_hid_report_t *report, uint8_t **report_desc, size_t *report_size)
 {
@@ -175 +175 @@
 //      size_t report_size;
         
-        int rc = usb_hid_get_report_descriptor(dev, report_desc, report_size);
+        errno_t rc = usb_hid_get_report_descriptor(dev, report_desc, report_size);
         
         if (rc != EOK) {