Changeset b7fd2a0 in mainline for uspace/srv/audio/hound/audio_source.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/audio/hound/audio_source.c (modified) (3 diffs)

uspace/srv/audio/hound/audio_source.c

@@ -56 +56 @@
  * @return Error code.
  */
-int audio_source_init(audio_source_t *source, const char *name, void *data,
-    int (*connection_change)(audio_source_t *, bool new),
-    int (*update_available_data)(audio_source_t *, size_t),
+errno_t audio_source_init(audio_source_t *source, const char *name, void *data,
+    errno_t (*connection_change)(audio_source_t *, bool new),
+    errno_t (*update_available_data)(audio_source_t *, size_t),
     const pcm_format_t *f)
 {
@@ -96 +96 @@
  * @return Error code.
  */
-int audio_source_push_data(audio_source_t *source, const void *data,
+errno_t audio_source_push_data(audio_source_t *source, const void *data,
     size_t size)
 {
@@ -107 +107 @@
 
         list_foreach(source->connections, source_link, connection_t, conn) {
-                const int ret = connection_push_data(conn, adata);
+                const errno_t ret = connection_push_data(conn, adata);
                 if (ret != EOK) {
                         log_warning("Failed push data to %s: %s",