Changeset b7fd2a0 in mainline for uspace/srv/audio/hound/hound.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/audio/hound/hound.h (modified) (1 diff)

uspace/srv/audio/hound/hound.h

@@ -65 +65 @@
 } hound_t;
 
-int hound_init(hound_t *hound);
-int hound_add_ctx(hound_t *hound, hound_ctx_t *ctx);
-int hound_remove_ctx(hound_t *hound, hound_ctx_t *ctx);
+errno_t hound_init(hound_t *hound);
+errno_t hound_add_ctx(hound_t *hound, hound_ctx_t *ctx);
+errno_t hound_remove_ctx(hound_t *hound, hound_ctx_t *ctx);
 hound_ctx_t *hound_get_ctx_by_id(hound_t *hound, hound_context_id_t id);
 
-int hound_add_device(hound_t *hound, service_id_t id, const char* name);
-int hound_add_source(hound_t *hound, audio_source_t *source);
-int hound_add_sink(hound_t *hound, audio_sink_t *sink);
-int hound_list_sources(hound_t *hound, const char ***list, size_t *size);
-int hound_list_sinks(hound_t *hound, const char ***list, size_t *size);
-int hound_list_connections(hound_t *hound, const char ***sources,
+errno_t hound_add_device(hound_t *hound, service_id_t id, const char* name);
+errno_t hound_add_source(hound_t *hound, audio_source_t *source);
+errno_t hound_add_sink(hound_t *hound, audio_sink_t *sink);
+errno_t hound_list_sources(hound_t *hound, const char ***list, size_t *size);
+errno_t hound_list_sinks(hound_t *hound, const char ***list, size_t *size);
+errno_t hound_list_connections(hound_t *hound, const char ***sources,
     const char ***sinks, size_t *size);
-int hound_remove_source(hound_t *hound, audio_source_t *source);
-int hound_remove_sink(hound_t *hound, audio_sink_t *sink);
-int hound_connect(hound_t *hound, const char* source_name, const char* sink_name);
-int hound_disconnect(hound_t *hound, const char* source_name, const char* sink_name);
+errno_t hound_remove_source(hound_t *hound, audio_source_t *source);
+errno_t hound_remove_sink(hound_t *hound, audio_sink_t *sink);
+errno_t hound_connect(hound_t *hound, const char* source_name, const char* sink_name);
+errno_t hound_disconnect(hound_t *hound, const char* source_name, const char* sink_name);
 
 #endif