Changeset b7fd2a0 in mainline for uspace/srv/bd/vbd/disk.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/bd/vbd/disk.h (modified) (1 diff)

uspace/srv/bd/vbd/disk.h

@@ -42 +42 @@
 #include <vbd.h>
 
-extern int vbds_disks_init(void);
-extern int vbds_disk_discovery_start(void);
-extern int vbds_disk_add(service_id_t);
-extern int vbds_disk_remove(service_id_t);
-extern int vbds_disk_get_ids(service_id_t *, size_t, size_t *);
-extern int vbds_disk_info(service_id_t, vbd_disk_info_t *);
-extern int vbds_get_parts(service_id_t, service_id_t *, size_t, size_t *);
-extern int vbds_label_create(service_id_t, label_type_t);
-extern int vbds_label_delete(service_id_t);
-extern int vbds_part_get_info(vbds_part_id_t, vbd_part_info_t *);
-extern int vbds_part_create(service_id_t, vbd_part_spec_t *,vbds_part_id_t *);
-extern int vbds_part_delete(vbds_part_id_t);
-extern int vbds_suggest_ptype(service_id_t, label_pcnt_t, label_ptype_t *);
+extern errno_t vbds_disks_init(void);
+extern errno_t vbds_disk_discovery_start(void);
+extern errno_t vbds_disk_add(service_id_t);
+extern errno_t vbds_disk_remove(service_id_t);
+extern errno_t vbds_disk_get_ids(service_id_t *, size_t, size_t *);
+extern errno_t vbds_disk_info(service_id_t, vbd_disk_info_t *);
+extern errno_t vbds_get_parts(service_id_t, service_id_t *, size_t, size_t *);
+extern errno_t vbds_label_create(service_id_t, label_type_t);
+extern errno_t vbds_label_delete(service_id_t);
+extern errno_t vbds_part_get_info(vbds_part_id_t, vbd_part_info_t *);
+extern errno_t vbds_part_create(service_id_t, vbd_part_spec_t *,vbds_part_id_t *);
+extern errno_t vbds_part_delete(vbds_part_id_t);
+extern errno_t vbds_suggest_ptype(service_id_t, label_pcnt_t, label_ptype_t *);
 extern void vbds_bd_conn(ipc_callid_t, ipc_call_t *, void *);