Changeset b7fd2a0 in mainline for uspace/srv/fs/exfat/exfat_bitmap.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/fs/exfat/exfat_bitmap.c (modified) (12 diffs)

uspace/srv/fs/exfat/exfat_bitmap.c

@@ -48 +48 @@
 
 
-int exfat_bitmap_is_free(exfat_bs_t *bs, service_id_t service_id, 
+errno_t exfat_bitmap_is_free(exfat_bs_t *bs, service_id_t service_id, 
     exfat_cluster_t clst)
 {
@@ -55 +55 @@
         exfat_node_t *bitmapp;
         uint8_t *bitmap;
-        int rc;
+        errno_t rc;
         bool alloc;
 
@@ -89 +89 @@
 }
 
-int exfat_bitmap_set_cluster(exfat_bs_t *bs, service_id_t service_id, 
+errno_t exfat_bitmap_set_cluster(exfat_bs_t *bs, service_id_t service_id, 
     exfat_cluster_t clst)
 {
@@ -96 +96 @@
         exfat_node_t *bitmapp;
         uint8_t *bitmap;
-        int rc;
+        errno_t rc;
 
         clst -= EXFAT_CLST_FIRST;
@@ -124 +124 @@
 }
 
-int exfat_bitmap_clear_cluster(exfat_bs_t *bs, service_id_t service_id, 
+errno_t exfat_bitmap_clear_cluster(exfat_bs_t *bs, service_id_t service_id, 
     exfat_cluster_t clst)
 {
@@ -131 +131 @@
         exfat_node_t *bitmapp;
         uint8_t *bitmap;
-        int rc;
+        errno_t rc;
 
         clst -= EXFAT_CLST_FIRST;
@@ -160 +160 @@
 }
 
-int exfat_bitmap_set_clusters(exfat_bs_t *bs, service_id_t service_id, 
+errno_t exfat_bitmap_set_clusters(exfat_bs_t *bs, service_id_t service_id, 
     exfat_cluster_t firstc, exfat_cluster_t count)
 {
-        int rc;
+        errno_t rc;
         exfat_cluster_t clst;
         clst = firstc;
@@ -180 +180 @@
 }
 
-int exfat_bitmap_clear_clusters(exfat_bs_t *bs, service_id_t service_id, 
+errno_t exfat_bitmap_clear_clusters(exfat_bs_t *bs, service_id_t service_id, 
     exfat_cluster_t firstc, exfat_cluster_t count)
 {
-        int rc;
+        errno_t rc;
         exfat_cluster_t clst;
         clst = firstc;
@@ -196 +196 @@
 }
 
-int exfat_bitmap_alloc_clusters(exfat_bs_t *bs, service_id_t service_id, 
+errno_t exfat_bitmap_alloc_clusters(exfat_bs_t *bs, service_id_t service_id, 
     exfat_cluster_t *firstc, exfat_cluster_t count)
 {
@@ -217 +217 @@
 
 
-int exfat_bitmap_append_clusters(exfat_bs_t *bs, exfat_node_t *nodep, 
+errno_t exfat_bitmap_append_clusters(exfat_bs_t *bs, exfat_node_t *nodep, 
     exfat_cluster_t count)
 {
@@ -240 +240 @@
 
 
-int exfat_bitmap_free_clusters(exfat_bs_t *bs, exfat_node_t *nodep, 
+errno_t exfat_bitmap_free_clusters(exfat_bs_t *bs, exfat_node_t *nodep, 
     exfat_cluster_t count)
 {
@@ -251 +251 @@
 
 
-int exfat_bitmap_replicate_clusters(exfat_bs_t *bs, exfat_node_t *nodep)
-{
-        int rc;
+errno_t exfat_bitmap_replicate_clusters(exfat_bs_t *bs, exfat_node_t *nodep)
+{
+        errno_t rc;
         exfat_cluster_t lastc, clst;
         service_id_t service_id = nodep->idx->service_id;