Changeset b7fd2a0 in mainline for uspace/srv/fs/exfat/exfat_idx.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/fs/exfat/exfat_idx.c (modified) (5 diffs)

uspace/srv/fs/exfat/exfat_idx.c

@@ -328 +328 @@
 }
 
-static int exfat_idx_create(exfat_idx_t **fidxp, service_id_t service_id)
+static errno_t exfat_idx_create(exfat_idx_t **fidxp, service_id_t service_id)
 {
         exfat_idx_t *fidx;
@@ -350 +350 @@
 }
 
-int exfat_idx_get_new(exfat_idx_t **fidxp, service_id_t service_id)
+errno_t exfat_idx_get_new(exfat_idx_t **fidxp, service_id_t service_id)
 {
         exfat_idx_t *fidx;
-        int rc;
+        errno_t rc;
 
         fibril_mutex_lock(&used_lock);
@@ -386 +386 @@
                 fidx = hash_table_get_inst(l, exfat_idx_t, uph_link);
         } else {
-                int rc;
+                errno_t rc;
 
                 rc = exfat_idx_create(&fidx, service_id);
@@ -468 +468 @@
 }
 
-int exfat_idx_init(void)
+errno_t exfat_idx_init(void)
 {
         if (!hash_table_create(&up_hash, 0, 0, &uph_ops)) 
@@ -487 +487 @@
 }
 
-int exfat_idx_init_by_service_id(service_id_t service_id)
+errno_t exfat_idx_init_by_service_id(service_id_t service_id)
 {
         unused_t *u;
-        int rc = EOK;
+        errno_t rc = EOK;
 
         u = (unused_t *) malloc(sizeof(unused_t));