Changeset b7fd2a0 in mainline for uspace/srv/hid/input/port/chardev.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/hid/input/port/chardev.c (modified) (4 diffs)

uspace/srv/hid/input/port/chardev.c

@@ -45 +45 @@
 #include "../kbd.h"
 
-static int kbd_port_fibril(void *);
+static errno_t kbd_port_fibril(void *);
 
-static int chardev_port_init(kbd_dev_t *);
+static errno_t chardev_port_init(kbd_dev_t *);
 static void chardev_port_write(uint8_t);
 
@@ -69 +69 @@
 static const unsigned int num_devs = sizeof(in_devs) / sizeof(in_devs[0]);
 
-static int chardev_port_init(kbd_dev_t *kdev)
+static errno_t chardev_port_init(kbd_dev_t *kdev)
 {
         service_id_t service_id;
         unsigned int i;
         fid_t fid;
-        int rc;
+        errno_t rc;
         
         kbd_dev = kdev;
@@ -121 +121 @@
 static void chardev_port_write(uint8_t data)
 {
-        int rc;
+        errno_t rc;
         size_t nwr;
 
@@ -131 +131 @@
 }
 
-static int kbd_port_fibril(void *arg)
+static errno_t kbd_port_fibril(void *arg)
 {
-        int rc;
+        errno_t rc;
         size_t nread;
         uint8_t b;