Changeset b7fd2a0 in mainline for uspace/srv/hid/output/port/chardev.c


Ignore:
Timestamp:
2018-01-13T03:10:29Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/srv/hid/output/port/chardev.c

    r36f0738 rb7fd2a0  
    9999        service_id_t *svc;
    100100        size_t svcs;
    101         int rc;
     101        errno_t rc;
    102102
    103103        rc = loc_category_get_svcs(serial_cat_id, &svc, &svcs);
     
    157157static void check_for_dev(void)
    158158{
    159         int rc;
     159        errno_t rc;
    160160        bool found;
    161161        service_id_t sid;
     
    205205}
    206206
    207 int chardev_init(void)
     207errno_t chardev_init(void)
    208208{
    209209        if (!config_key_exists("console")) {
     
    224224        }
    225225
    226         int rc = loc_category_get_id("serial", &serial_cat_id, IPC_FLAG_BLOCKING);
     226        errno_t rc = loc_category_get_id("serial", &serial_cat_id, IPC_FLAG_BLOCKING);
    227227        if (rc != EOK) {
    228228                printf("%s: Failed to get \"serial\" category ID.\n", NAME);
Note: See TracChangeset for help on using the changeset viewer.