Changeset b7fd2a0 in mainline for uspace/srv/loader/main.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/loader/main.c (modified) (6 diffs)

uspace/srv/loader/main.c

@@ -119 +119 @@
 {
         char *buf;
-        int rc = async_data_write_accept((void **) &buf, true, 0, 0, 0, NULL);
+        errno_t rc = async_data_write_accept((void **) &buf, true, 0, 0, 0, NULL);
         
         if (rc == EOK) {
@@ -146 +146 @@
 
         char* name = malloc(namesize);
-        int rc = async_data_write_finalize(writeid, name, namesize);
+        errno_t rc = async_data_write_finalize(writeid, name, namesize);
         if (rc != EOK) {
                 async_answer_0(rid, EINVAL);
@@ -173 +173 @@
         char *buf;
         size_t buf_size;
-        int rc = async_data_write_accept((void **) &buf, true, 0, 0, 0, &buf_size);
+        errno_t rc = async_data_write_accept((void **) &buf, true, 0, 0, 0, &buf_size);
         
         if (rc == EOK) {
@@ -249 +249 @@
 
         char* name = malloc(namesize);
-        int rc = async_data_write_finalize(writeid, name, namesize);
+        errno_t rc = async_data_write_finalize(writeid, name, namesize);
         if (rc != EOK) {
                 async_answer_0(rid, EINVAL);
@@ -349 +349 @@
         
         while (true) {
-                int retval;
+                errno_t retval;
                 ipc_call_t call;
                 ipc_callid_t callid = async_get_call(&call);
@@ -395 +395 @@
         /* Introduce this task to the NS (give it our task ID). */
         task_id_t id = task_get_id();
-        int rc = ns_intro(id);
+        errno_t rc = ns_intro(id);
         if (rc != EOK)
                 return rc;