Changeset b7fd2a0 in mainline for uspace/srv/logger/ctl.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/logger/ctl.c (modified) (3 diffs)

uspace/srv/logger/ctl.c

@@ -43 +43 @@
 #include "logger.h"
 
-static int handle_log_level_change(sysarg_t new_level)
+static errno_t handle_log_level_change(sysarg_t new_level)
 {
         void *full_name;
-        int rc = async_data_write_accept(&full_name, true, 0, 0, 0, NULL);
+        errno_t rc = async_data_write_accept(&full_name, true, 0, 0, 0, NULL);
         if (rc != EOK) {
                 return rc;
@@ -77 +77 @@
                 switch (IPC_GET_IMETHOD(call)) {
                 case LOGGER_CONTROL_SET_DEFAULT_LEVEL: {
-                        int rc = set_default_logging_level(IPC_GET_ARG1(call));
+                        errno_t rc = set_default_logging_level(IPC_GET_ARG1(call));
                         async_answer_0(callid, rc);
                         break;
                 }
                 case LOGGER_CONTROL_SET_LOG_LEVEL: {
-                        int rc = handle_log_level_change(IPC_GET_ARG1(call));
+                        errno_t rc = handle_log_level_change(IPC_GET_ARG1(call));
                         async_answer_0(callid, rc);
                         break;
@@ -88 +88 @@
                 case LOGGER_CONTROL_SET_ROOT: {
                         int fd;
-                        int rc = vfs_receive_handle(true, &fd);
+                        errno_t rc = vfs_receive_handle(true, &fd);
                         if (rc == EOK) {
                                 rc = vfs_root_set(fd);