Changeset b7fd2a0 in mainline for uspace/srv/net/inetsrv/ndp.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/inetsrv/ndp.c (modified) (5 diffs)

uspace/srv/net/inetsrv/ndp.c

@@ -64 +64 @@
 }
 
-static int ndp_send_packet(inet_link_t *link, ndp_packet_t *packet)
+static errno_t ndp_send_packet(inet_link_t *link, ndp_packet_t *packet)
 {
         inet_dgram_t dgram;
@@ -77 +77 @@
 }
 
-static int ndp_router_advertisement(inet_dgram_t *dgram, inet_addr_t *router)
+static errno_t ndp_router_advertisement(inet_dgram_t *dgram, inet_addr_t *router)
 {
         // FIXME TODO
@@ -83 +83 @@
 }
 
-int ndp_received(inet_dgram_t *dgram)
+errno_t ndp_received(inet_dgram_t *dgram)
 {
         log_msg(LOG_DEFAULT, LVL_DEBUG, "ndp_received()");
         
         ndp_packet_t packet;
-        int rc = ndp_pdu_decode(dgram, &packet);
+        errno_t rc = ndp_pdu_decode(dgram, &packet);
         if (rc != EOK)
                 return rc;
@@ -151 +151 @@
  *
  */
-int ndp_translate(addr128_t src_addr, addr128_t ip_addr, addr48_t mac_addr,
+errno_t ndp_translate(addr128_t src_addr, addr128_t ip_addr, addr48_t mac_addr,
     inet_link_t *ilink)
 {
@@ -160 +160 @@
         }
         
-        int rc = ntrans_lookup(ip_addr, mac_addr);
+        errno_t rc = ntrans_lookup(ip_addr, mac_addr);
         if (rc == EOK)
                 return EOK;