Changeset b7fd2a0 in mainline for uspace/srv/vfs/vfs.h


Ignore:
Timestamp:
2018-01-13T03:10:29Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • uspace/srv/vfs/vfs.h

    r36f0738 rb7fd2a0  
    176176extern fs_handle_t fs_name_to_handle(unsigned int instance, const char *, bool);
    177177extern vfs_info_t *fs_handle_to_info(fs_handle_t);
    178 extern int vfs_get_fstypes(vfs_fstypes_t *);
    179 
    180 extern int vfs_lookup_internal(vfs_node_t *, char *, int, vfs_lookup_res_t *);
    181 extern int vfs_link_internal(vfs_node_t *, char *, vfs_triplet_t *);
     178extern errno_t vfs_get_fstypes(vfs_fstypes_t *);
     179
     180extern errno_t vfs_lookup_internal(vfs_node_t *, char *, int, vfs_lookup_res_t *);
     181extern errno_t vfs_link_internal(vfs_node_t *, char *, vfs_triplet_t *);
    182182
    183183extern bool vfs_nodes_init(void);
    … …  
    194194
    195195extern void vfs_op_pass_handle(task_id_t, task_id_t, int);
    196 extern int vfs_wait_handle_internal(bool, int *);
     196extern errno_t vfs_wait_handle_internal(bool, int *);
    197197
    198198extern vfs_file_t *vfs_file_get(int);
    199199extern void vfs_file_put(vfs_file_t *);
    200 extern int vfs_fd_assign(vfs_file_t *, int);
    201 extern int vfs_fd_alloc(vfs_file_t **file, bool desc, int *);
    202 extern int vfs_fd_free(int);
     200extern errno_t vfs_fd_assign(vfs_file_t *, int);
     201extern errno_t vfs_fd_alloc(vfs_file_t **file, bool desc, int *);
     202extern errno_t vfs_fd_free(int);
    203203
    204204extern void vfs_node_addref(vfs_node_t *);
    205205extern void vfs_node_delref(vfs_node_t *);
    206 extern int vfs_open_node_remote(vfs_node_t *);
    207 
    208 extern int vfs_op_clone(int oldfd, int newfd, bool desc, int *);
    209 extern int vfs_op_fsprobe(const char *, service_id_t, vfs_fs_probe_info_t *);
    210 extern int vfs_op_mount(int mpfd, unsigned servid, unsigned flags, unsigned instance, const char *opts, const char *fsname, int *outfd);
    211 extern int vfs_op_mtab_get(void);
    212 extern int vfs_op_open(int fd, int flags);
    213 extern int vfs_op_put(int fd);
    214 extern int vfs_op_read(int fd, aoff64_t, size_t *out_bytes);
    215 extern int vfs_op_rename(int basefd, char *old, char *new);
    216 extern int vfs_op_resize(int fd, int64_t size);
    217 extern int vfs_op_stat(int fd);
    218 extern int vfs_op_statfs(int fd);
    219 extern int vfs_op_sync(int fd);
    220 extern int vfs_op_unlink(int parentfd, int expectfd, char *path);
    221 extern int vfs_op_unmount(int mpfd);
    222 extern int vfs_op_wait_handle(bool high_fd, int *out_fd);
    223 extern int vfs_op_walk(int parentfd, int flags, char *path, int *out_fd);
    224 extern int vfs_op_write(int fd, aoff64_t, size_t *out_bytes);
     206extern errno_t vfs_open_node_remote(vfs_node_t *);
     207
     208extern errno_t vfs_op_clone(int oldfd, int newfd, bool desc, int *);
     209extern errno_t vfs_op_fsprobe(const char *, service_id_t, vfs_fs_probe_info_t *);
     210extern errno_t vfs_op_mount(int mpfd, unsigned servid, unsigned flags, unsigned instance, const char *opts, const char *fsname, int *outfd);
     211extern errno_t vfs_op_mtab_get(void);
     212extern errno_t vfs_op_open(int fd, int flags);
     213extern errno_t vfs_op_put(int fd);
     214extern errno_t vfs_op_read(int fd, aoff64_t, size_t *out_bytes);
     215extern errno_t vfs_op_rename(int basefd, char *old, char *new);
     216extern errno_t vfs_op_resize(int fd, int64_t size);
     217extern errno_t vfs_op_stat(int fd);
     218extern errno_t vfs_op_statfs(int fd);
     219extern errno_t vfs_op_sync(int fd);
     220extern errno_t vfs_op_unlink(int parentfd, int expectfd, char *path);
     221extern errno_t vfs_op_unmount(int mpfd);
     222extern errno_t vfs_op_wait_handle(bool high_fd, int *out_fd);
     223extern errno_t vfs_op_walk(int parentfd, int flags, char *path, int *out_fd);
     224extern errno_t vfs_op_write(int fd, aoff64_t, size_t *out_bytes);
    225225
    226226extern void vfs_register(ipc_callid_t, ipc_call_t *);
    … …  
    233233} rdwr_io_chunk_t;
    234234
    235 extern int vfs_rdwr_internal(int, aoff64_t, bool, rdwr_io_chunk_t *);
     235extern errno_t vfs_rdwr_internal(int, aoff64_t, bool, rdwr_io_chunk_t *);
    236236
    237237extern void vfs_connection(ipc_callid_t iid, ipc_call_t *icall, void *arg);
Note: See TracChangeset for help on using the changeset viewer.