Changeset da1bafb in mainline for kernel/generic/src/cpu/cpu.c

Timestamp:

2010-05-24T18:57:31Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0095368

Parents:

666f492

Message:

major code revision

• replace spinlocks taken with interrupts disabled with irq_spinlocks
• change spacing (not indendation) to be tab-size independent
• use unsigned integer types where appropriate (especially bit flags)
• visual separation
• remove argument names in function prototypes
• string changes
• correct some formating directives
• replace various cryptic single-character variables (t, a, m, c, b, etc.) with proper identifiers (thread, task, timeout, as, itm, itc, etc.)
• unify some assembler constructs
• unused page table levels are now optimized out in compile time
• replace several ints (with boolean semantics) with bools
• use specifically sized types instead of generic types where appropriate (size_t, uint32_t, btree_key_t)
• improve comments
• split asserts with conjuction into multiple independent asserts

File:

• kernel/generic/src/cpu/cpu.c (modified) (4 diffs)

kernel/generic/src/cpu/cpu.c

@@ -33 +33 @@
 /**
  * @file
- * @brief       CPU subsystem initialization and listing.
+ * @brief CPU subsystem initialization and listing.
  */
- 
+
 #include <cpu.h>
 #include <arch.h>
@@ -58 +58 @@
  */
 void cpu_init(void) {
-        unsigned int i, j;
-        
 #ifdef CONFIG_SMP
         if (config.cpu_active == 1) {
 #endif /* CONFIG_SMP */
+                
                 cpus = (cpu_t *) malloc(sizeof(cpu_t) * config.cpu_count,
-                                        FRAME_ATOMIC);
+                    FRAME_ATOMIC);
                 if (!cpus)
                         panic("Cannot allocate CPU structures.");
-
-                /* initialize everything */
+                
+                /* Initialize everything */
                 memsetb(cpus, sizeof(cpu_t) * config.cpu_count, 0);
-
+                
+                size_t i;
                 for (i = 0; i < config.cpu_count; i++) {
-                        cpus[i].stack = (uint8_t *) frame_alloc(STACK_FRAMES, FRAME_KA | FRAME_ATOMIC);
-                        
+                        cpus[i].stack = (uint8_t *) frame_alloc(STACK_FRAMES,
+                            FRAME_KA | FRAME_ATOMIC);
                         cpus[i].id = i;
                         
-                        spinlock_initialize(&cpus[i].lock, "cpu_t.lock");
-
+                        irq_spinlock_initialize(&cpus[i].lock, "cpus[].lock");
+                        
+                        unsigned int j;
                         for (j = 0; j < RQ_COUNT; j++) {
-                                spinlock_initialize(&cpus[i].rq[j].lock, "rq_t.lock");
+                                irq_spinlock_initialize(&cpus[i].rq[j].lock, "cpus[].rq[].lock");
                                 list_initialize(&cpus[i].rq[j].rq_head);
                         }
@@ -87 +88 @@
         }
 #endif /* CONFIG_SMP */
-
+        
         CPU = &cpus[config.cpu_active - 1];
         
-        CPU->active = 1;
-        CPU->tlb_active = 1;
+        CPU->active = true;
+        CPU->tlb_active = true;
         
         cpu_identify();
@@ -100 +101 @@
 void cpu_list(void)
 {
-        unsigned int i;
-
+        size_t i;
+        
         for (i = 0; i < config.cpu_count; i++) {
                 if (cpus[i].active)