Changeset eb13ef8 in mainline for uspace/lib/c/generic/async/server.c

Timestamp:

2019-02-06T13:25:12Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fafb8e5

Parents:

bb97118

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-02 14:04:02)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-06 13:25:12)

Message:

Change IPC_GET_* and IPC_SET_* to accept pointer instead of lvalue

File:

• uspace/lib/c/generic/async/server.c (modified) (12 diffs)

uspace/lib/c/generic/async/server.c

@@ -546 +546 @@
         errno_t rc = mpsc_send(conn->msg_channel, call);
 
-        if (IPC_GET_IMETHOD(*call) == IPC_M_PHONE_HUNGUP) {
+        if (IPC_GET_IMETHOD(call) == IPC_M_PHONE_HUNGUP) {
                 /* Close the channel, but let the connection fibril answer. */
                 mpsc_close(conn->msg_channel);
@@ -657 +657 @@
 
         ht_link_t *link = hash_table_find(&notification_hash_table,
-            &IPC_GET_IMETHOD(*call));
+            &IPC_GET_IMETHOD(call));
         if (!link) {
                 /* Invalid notification. */
@@ -871 +871 @@
 
                 memset(call, 0, sizeof(ipc_call_t));
-                IPC_SET_IMETHOD(*call, IPC_M_PHONE_HUNGUP);
+                IPC_SET_IMETHOD(call, IPC_M_PHONE_HUNGUP);
                 call->cap_handle = CAP_NIL;
         }
@@ -944 +944 @@
 
         /* New connection */
-        if (IPC_GET_IMETHOD(*call) == IPC_M_CONNECT_ME_TO) {
+        if (IPC_GET_IMETHOD(call) == IPC_M_CONNECT_ME_TO) {
                 connection_t *conn = calloc(1, sizeof(*conn));
                 if (!conn) {
@@ -951 +951 @@
                 }
 
-                iface_t iface = (iface_t) IPC_GET_ARG1(*call);
+                iface_t iface = (iface_t) IPC_GET_ARG1(call);
 
                 // TODO: Currently ignores all ports but the first one.
@@ -1221 +1221 @@
         async_get_call(call);
 
-        if (IPC_GET_IMETHOD(*call) != IPC_M_SHARE_IN)
+        if (IPC_GET_IMETHOD(call) != IPC_M_SHARE_IN)
                 return false;
 
-        *size = (size_t) IPC_GET_ARG1(*call);
+        *size = (size_t) IPC_GET_ARG1(call);
         return true;
 }
@@ -1276 +1276 @@
         async_get_call(call);
 
-        if (IPC_GET_IMETHOD(*call) != IPC_M_SHARE_OUT)
+        if (IPC_GET_IMETHOD(call) != IPC_M_SHARE_OUT)
                 return false;
 
-        *size = (size_t) IPC_GET_ARG2(*call);
-        *flags = (unsigned int) IPC_GET_ARG3(*call);
+        *size = (size_t) IPC_GET_ARG2(call);
+        *flags = (unsigned int) IPC_GET_ARG3(call);
         return true;
 }
@@ -1329 +1329 @@
         async_get_call(call);
 
-        if (IPC_GET_IMETHOD(*call) != IPC_M_DATA_READ)
+        if (IPC_GET_IMETHOD(call) != IPC_M_DATA_READ)
                 return false;
 
         if (size)
-                *size = (size_t) IPC_GET_ARG2(*call);
+                *size = (size_t) IPC_GET_ARG2(call);
 
         return true;
@@ -1488 +1488 @@
         async_get_call(call);
 
-        if (IPC_GET_IMETHOD(*call) != IPC_M_DATA_WRITE)
+        if (IPC_GET_IMETHOD(call) != IPC_M_DATA_WRITE)
                 return false;
 
         if (size)
-                *size = (size_t) IPC_GET_ARG2(*call);
+                *size = (size_t) IPC_GET_ARG2(call);
 
         return true;
@@ -1732 +1732 @@
         async_get_call(&call);
 
-        cap_phone_handle_t phandle = (cap_handle_t) IPC_GET_ARG5(call);
-
-        if ((IPC_GET_IMETHOD(call) != IPC_M_CONNECT_TO_ME) ||
+        cap_phone_handle_t phandle = (cap_handle_t) IPC_GET_ARG5(&call);
+
+        if ((IPC_GET_IMETHOD(&call) != IPC_M_CONNECT_TO_ME) ||
             !cap_handle_valid((phandle))) {
                 async_answer_0(&call, EINVAL);
@@ -1776 +1776 @@
 async_sess_t *async_callback_receive_start(exch_mgmt_t mgmt, ipc_call_t *call)
 {
-        cap_phone_handle_t phandle = (cap_handle_t) IPC_GET_ARG5(*call);
-
-        if ((IPC_GET_IMETHOD(*call) != IPC_M_CONNECT_TO_ME) ||
+        cap_phone_handle_t phandle = (cap_handle_t) IPC_GET_ARG5(call);
+
+        if ((IPC_GET_IMETHOD(call) != IPC_M_CONNECT_TO_ME) ||
             !cap_handle_valid((phandle)))
                 return NULL;
@@ -1803 +1803 @@
         async_get_call(call);
 
-        if (IPC_GET_IMETHOD(*call) != IPC_M_STATE_CHANGE_AUTHORIZE)
+        if (IPC_GET_IMETHOD(call) != IPC_M_STATE_CHANGE_AUTHORIZE)
                 return false;