Changeset eb13ef8 in mainline for uspace/lib/hound/src/protocol.c

Timestamp:

2019-02-06T13:25:12Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fafb8e5

Parents:

bb97118

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-02 14:04:02)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-06 13:25:12)

Message:

Change IPC_GET_* and IPC_SET_* to accept pointer instead of lvalue

File:

• uspace/lib/hound/src/protocol.c (modified) (12 diffs)

uspace/lib/hound/src/protocol.c

@@ -140 +140 @@
         async_exchange_end(exch);
         if (ret == EOK) {
-                *id = (hound_context_id_t) IPC_GET_ARG1(call);
+                *id = (hound_context_id_t) IPC_GET_ARG1(&call);
         }
 
@@ -203 +203 @@
                 return ret;
         }
-        unsigned name_count = IPC_GET_ARG1(res_call);
+        unsigned name_count = IPC_GET_ARG1(&res_call);
 
         /* Start receiving names */
@@ -406 +406 @@
                 async_get_call(&call);
 
-                switch (IPC_GET_IMETHOD(call)) {
+                switch (IPC_GET_IMETHOD(&call)) {
                 case IPC_M_HOUND_CONTEXT_REGISTER:
                         /* check interface functions */
@@ -413 +413 @@
                                 break;
                         }
-                        bool record = IPC_GET_ARG1(call);
+                        bool record = IPC_GET_ARG1(&call);
                         void *name;
 
@@ -442 +442 @@
 
                         /* get id, 1st param */
-                        context = (hound_context_id_t) IPC_GET_ARG1(call);
+                        context = (hound_context_id_t) IPC_GET_ARG1(&call);
                         ret = server_iface->rem_context(server_iface->server,
                             context);
@@ -455 +455 @@
 
                         char **list = NULL;
-                        flags = IPC_GET_ARG1(call);
-                        size_t count = IPC_GET_ARG2(call);
-                        const bool conn = IPC_GET_ARG3(call);
+                        flags = IPC_GET_ARG1(&call);
+                        size_t count = IPC_GET_ARG2(&call);
+                        const bool conn = IPC_GET_ARG3(&call);
                         char *conn_name = NULL;
                         ret = EOK;
@@ -568 +568 @@
 
                         /* get parameters */
-                        context = (hound_context_id_t) IPC_GET_ARG1(call);
-                        flags = IPC_GET_ARG2(call);
-                        const format_convert_t c = { .arg = IPC_GET_ARG3(call) };
+                        context = (hound_context_id_t) IPC_GET_ARG1(&call);
+                        flags = IPC_GET_ARG2(&call);
+                        const format_convert_t c = { .arg = IPC_GET_ARG3(&call) };
                         const pcm_format_t f = {
                                 .sampling_rate = c.f.rate * 100,
@@ -576 +576 @@
                                 .sample_format = c.f.format,
                         };
-                        size_t bsize = IPC_GET_ARG4(call);
+                        size_t bsize = IPC_GET_ARG4(&call);
 
                         void *stream;
@@ -640 +640 @@
         /* accept data write or drain */
         while (async_data_write_receive(&call, &size) ||
-            (IPC_GET_IMETHOD(call) == IPC_M_HOUND_STREAM_DRAIN)) {
+            (IPC_GET_IMETHOD(&call) == IPC_M_HOUND_STREAM_DRAIN)) {
                 /* check drain first */
-                if (IPC_GET_IMETHOD(call) == IPC_M_HOUND_STREAM_DRAIN) {
+                if (IPC_GET_IMETHOD(&call) == IPC_M_HOUND_STREAM_DRAIN) {
                         errno_t ret = ENOTSUP;
                         if (server_iface->drain_stream)
@@ -668 +668 @@
                 }
         }
-        const errno_t ret = IPC_GET_IMETHOD(call) == IPC_M_HOUND_STREAM_EXIT ?
+        const errno_t ret = IPC_GET_IMETHOD(&call) == IPC_M_HOUND_STREAM_EXIT ?
             EOK : EINVAL;
 
@@ -687 +687 @@
         /* accept data read and drain */
         while (async_data_read_receive(&call, &size) ||
-            (IPC_GET_IMETHOD(call) == IPC_M_HOUND_STREAM_DRAIN)) {
+            (IPC_GET_IMETHOD(&call) == IPC_M_HOUND_STREAM_DRAIN)) {
                 /* drain does not make much sense but it is allowed */
-                if (IPC_GET_IMETHOD(call) == IPC_M_HOUND_STREAM_DRAIN) {
+                if (IPC_GET_IMETHOD(&call) == IPC_M_HOUND_STREAM_DRAIN) {
                         errno_t ret = ENOTSUP;
                         if (server_iface->drain_stream)
@@ -712 +712 @@
                 }
         }
-        const errno_t ret = IPC_GET_IMETHOD(call) == IPC_M_HOUND_STREAM_EXIT ?
+        const errno_t ret = IPC_GET_IMETHOD(&call) == IPC_M_HOUND_STREAM_EXIT ?
             EOK : EINVAL;