Changeset dd7df1c in mainline for uspace/lib/c/generic/rtld/symbol.c

Timestamp:

2023-10-22T17:26:17Z (17 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

dcef1127

Parents:

71b4444

git-author:

Vojtech Horky <vojtech.horky@…> (2023-07-14 09:54:21)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-10-22 17:26:17)

Message:

Silence spurious/unwanted GCC warnings using pragmas

File:

• uspace/lib/c/generic/rtld/symbol.c (modified) (1 diff)

uspace/lib/c/generic/rtld/symbol.c

@@ -135 +135 @@
         modules_untag(start->rtld);
 
-        /* Insert root (the program) into the queue and tag it */
+        /*
+         * Insert root (the program) into the queue and tag it.
+         *
+         * We disable the dangling-pointer warning because the compiler incorrectly
+         * assumes that we leak local address (queue) to a parent scope (to start
+         * argument). However, we always empty the list so the pointer cannot
+         * actually escape. Probably the compiler can never statically analyze that
+         * correctly.
+         */
         list_initialize(&queue);
         start->bfs_tag = true;
+#pragma GCC diagnostic push
+#if defined(__GNUC__) && (__GNUC__ >= 12)
+#pragma GCC diagnostic ignored "-Wdangling-pointer"
+#endif
         list_append(&start->queue_link, &queue);
+#pragma GCC diagnostic pop
 
         /* If the symbol is found, it will be stored in 'sym' */